ES2015 transformation for private properties (WIP, Joey Watts) #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheiber
changed the title
do a really rough, quick-and-dirty unblock-people job of letting #foo be parse-able. steps to test: npm run lint && npm test See https://bbgithub.dev.bloomberg.com/javascript-guild/typescript-private-fields/ quick start guide for seeing the AST CI testing coming soon
* jenkinsfile * add npm run build step * lint * baseline change * accept more baselines * accept baselines * fix-scanner * baselines again
mheiber
force-pushed
the
es2015-transformation
branch
from
54d8ef9 to
1497ca2
Compare
added 3 commits
July 3, 2018 14:23
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
joeywatts
changed the title
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
mheiber
commented
Jul 10, 2018
src/compiler/transformers/esnext.ts
Outdated
| return visitParenthesizedExpression(node as ParenthesizedExpression, noDestructuringValue); | ||
| case SyntaxKind.CatchClause: | ||
| return visitCatchClause(node as CatchClause); | ||
| case SyntaxKind.PropertyDeclaration: |
Owner
Author
There was a problem hiding this comment.
why did we need to add these new cases? Weren't they visited before?
Collaborator
There was a problem hiding this comment.
The esnext transformer didn't need any special behavior with these SyntaxKinds until private names were introduced.
added 6 commits
July 19, 2018 16:53
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
Collaborator
|
Rebased off of the updated parser code, see new PR #10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
early work-in-progress from @joeywatts on transpiling private names to target ES2015